[PATCH] D156171: [AArch64][GlobalISel] G_FMINNUM and G_FMAXNUM vector lowering

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 06:40:57 PDT 2023


arsenm added a comment.

In D156171#4531873 <https://reviews.llvm.org/D156171#4531873>, @tschuett wrote:

> May I ask you to add :
>
>   ...
>   ---
>   name:            3xs32_legal_with_full_fp16
>   alignment:       4
>   body:             |
>     bb.0:
>       liveins: $h0, $h1
>       %a:_(<3 x s32>) = IMPLICIT_DEF
>       %b:_(<3 x s32>) = IMPLICIT_DEF
>       %minnum:_(<3 x s32>) = G_FMINNUM %a, %b
>       %c:_(<3 x s32>) = COPY %minnum(<3 x s32>)
>       RET_ReallyLR implicit %c
>
> to llvm/test/CodeGen/AArch64/GlobalISel/legalize-fminnum.mir?

This needs to use G_IMPLICIT_DEF, not IMPLICIT_DEF


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156171/new/

https://reviews.llvm.org/D156171



More information about the llvm-commits mailing list