[PATCH] D154075: [LoopVectorize] Add pre-commit tests for D152366

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 00:28:32 PDT 2023


fhahn added a comment.

Taking another look, I think we need a few more tests for cases not covered by the current tests:

- uncomputable BTC in the outer loop
- inner and outer inductions decreasing (constant step)
- inner and outer induction incremented by non-constant



================
Comment at: llvm/test/Transforms/LoopVectorize/runtime-checks-hoist.ll:745
+inner.loop:
+  %indvars.iv = phi i64 [ %indvars.iv.next, %inner.loop ], [ 0, %outer.loop ]
+  %8 = add nuw nsw i64 %indvars.iv, %4
----------------
nit: remove redundant indvars prefixes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154075/new/

https://reviews.llvm.org/D154075



More information about the llvm-commits mailing list