[PATCH] D155708: [AArch64][NFC] Call the API getVScaleRange directly

Allen zhong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 00:22:35 PDT 2023


Allen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetMachine.cpp:405
+    MinSVEVectorSize = CR.getUnsignedMin().getZExtValue() * 128;
+    MaxSVEVectorSize = CR.getUnsignedMax().getZExtValue() * 128;
   } else {
----------------
nikic wrote:
> I'm not sure this is going to do the right thing if there is no upper bound on the range. Won't the `* 128` overflow in that case?
This refactor doesn't reduces the range of the upper limit.
Maybe we assume there is no overflow because the  maximum value of vscale is **2048** for arm targets, https://reviews.llvm.org/D98030


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155708/new/

https://reviews.llvm.org/D155708



More information about the llvm-commits mailing list