[PATCH] D155708: [AArch64][NFC] Call the API getVScaleRange directly

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 05:52:40 PDT 2023


nikic added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetMachine.cpp:405
+    MinSVEVectorSize = CR.getUnsignedMin().getZExtValue() * 128;
+    MaxSVEVectorSize = CR.getUnsignedMax().getZExtValue() * 128;
   } else {
----------------
I'm not sure this is going to do the right thing if there is no upper bound on the range. Won't the `* 128` overflow in that case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155708/new/

https://reviews.llvm.org/D155708



More information about the llvm-commits mailing list