[PATCH] D156136: [BPF] Clean up SelLowering

[Alexei Starovoitov via Phabricator via llvm-commits]

ast requested changes to this revision.
ast added a comment.
This revision now requires changes to proceed.

I don't see a value in this "cleanup". Looks like code churn to me.



================
Comment at: llvm/lib/Target/BPF/BPFISelLowering.cpp:261
   switch (Opcode) {
-  default:
-    report_fatal_error("Unhandled custom legalization");
+  default: {
+    report_fatal_error("unhandled custom legalization: " + Twine(Opcode));
----------------
and here?


================
Comment at: llvm/lib/Target/BPF/BPFISelLowering.cpp:381
 
-const unsigned BPFTargetLowering::MaxArgs = 5;
+const size_t BPFTargetLowering::MaxArgs = 5;
 
----------------
pls drop


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156136/new/

https://reviews.llvm.org/D156136