[PATCH] D156136: [BPF] Clean up SelLowering

Tamir Duberstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 09:50:55 PDT 2023


tamird added inline comments.


================
Comment at: llvm/lib/Target/BPF/BPFISelLowering.cpp:84
     if (VT == MVT::i32) {
-      if (STI.getHasAlu32())
+      if (STI.getHasAlu32()) {
         continue;
----------------
ast wrote:
> Here and elsewhere.
> Did you miss Eduard's comment:
> - LLVM Coding Standards actually require brace-less if statements (link <https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements>)
I didn't miss it. The description on those guidelines is vague and leaves much in the hands of the author. Anyway, done, I guess.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156136/new/

https://reviews.llvm.org/D156136



More information about the llvm-commits mailing list