[PATCH] D156111: [LV] Ignore the option prefer-predicate-over-epilogue for target unspported mask

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 05:30:04 PDT 2023


david-arm added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.h:311
   bool preferPredicateOverEpilogue(TailFoldingInfo *TFI);
+  bool enableMaskedInterleavedAccessVectorization() const {
+    return ST->hasMVEIntegerOps();
----------------
Maybe I'm missing something, but this feels like quite a huge change that isn't described in the subject line or in the commit message? Currently for RISCV and ARM backends this always returns false.

Enabling this by default for two different targets could cause performance regressions, and I'm not sure this is what you actually want?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156111/new/

https://reviews.llvm.org/D156111



More information about the llvm-commits mailing list