[PATCH] D156088: [AMDGPU] - Mark inverse.ballot as divergent

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

> Mark inverse.ballot as divergent

I would say "not convergent". "divergent" is the opposite of "uniform". I don't think we use it to mean the opposite of "convergent", do we?



================
Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1941
   Intrinsic<[llvm_i32_ty], [llvm_i32_ty, llvm_i32_ty],
-            [IntrNoMem, IntrConvergent, IntrWillReturn, IntrNoCallback, IntrNoFree]>;
+            [IntrNoMem, IntrWillReturn, IntrNoCallback, IntrNoFree]>;
 
----------------
sameerds wrote:
> This is updating the wrong intrinsic. readlane is definitely convergent.
You've changed the wrong intrinsic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156088/new/

https://reviews.llvm.org/D156088