[PATCH] D156088: [AMDGPU] - Mark inverse.ballot as divergent

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds added a comment.

The change description and other places should say "inverse.ballot is not convergent". The keyword "divergent" is the opposite of "uniform". The opposite of convergent is simply "not convergent".



================
Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1941
   Intrinsic<[llvm_i32_ty], [llvm_i32_ty, llvm_i32_ty],
-            [IntrNoMem, IntrConvergent, IntrWillReturn, IntrNoCallback, IntrNoFree]>;
 
----------------
This is updating the wrong intrinsic. readlane is definitely convergent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156088/new/

https://reviews.llvm.org/D156088