[PATCH] D156040: [AMDGPU] Add dynamic stack bit info to kernel-resource-usage Rpass output for CoV5

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

In D156040#4525771 <https://reviews.llvm.org/D156040#4525771>, @crobeck wrote:

> It is part of the kernel meta data that is passed to the runtime to indicate the compiler can't determine the required stack amount use of the kernel and to tell the runtime it needs to check the value set from hipDeviceSetLimit.

I don't see how this conveys any information. The compiler writes the stack size to be allocated. If it doesn't know what is sufficient, it's going to request some maximum and hope for the best.

The runtime allocates the requested information. If it has a bit saying "but use less if you know that's safe", then it can do nothing with that bit unless it has extra information. If it has that extra information, it doesn't need this bit.

Therefore instead of adding printing stuff related to this Boolean flag, we should delete the Boolean flag.

What's the use case I'm missing which makes this flag necessary/beneficial?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156040/new/

https://reviews.llvm.org/D156040