[PATCH] D156040: [AMDGPU] Add dynamic stack bit info to kernel-resource-usage Rpass output for CoV5

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1305
                             CurrentProgramInfo.LDSSize);
+  if (CodeObjectVersion >= AMDGPU::AMDHSA_COV5) {
+    std::string UsesDynamicStackStr =
----------------
No reason to make this conditional on the version 


================
Comment at: llvm/test/CodeGen/AMDGPU/resource-optimization-remarks_COV5.ll:1
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx908 -pass-remarks-output=%t -pass-remarks-analysis=kernel-resource-usage -filetype=obj -o /dev/null %s 2>&1 | FileCheck -check-prefix=STDERR %s
+
----------------
Can just add to the existing remark test. Also, -filetype=null instead of -o /dev/null


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156040/new/

https://reviews.llvm.org/D156040