[PATCH] D154584: Improve collectEphemeralValues and use it in CodeGenPrepare

[Artur Pilipenko via Phabricator via llvm-commits]

apilipenko added a comment.

In D154584#4508666 <https://reviews.llvm.org/D154584#4508666>, @skatkov wrote:

> I wonder whether it will easier to review if I split this patch into three one:
>
> 1. Use wouldInstructionBeTriviallyDead instead of checking side-effect and terminator only to extend the scope of collecting ephemeral values
> 2. Use CodeMetrics utility in CodeGenPrepare
> 3. Extend the algorithm for collecting ephemeral values by checking cycles (induction variable case)

Each of these steps is a reasonable improvement to what we have today. Given these improvements are independent (e.g. we would benefit from the more accurate collection of ephemeral values even without the CGP piece), I think it makes sense to split up and review them separately.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154584/new/

https://reviews.llvm.org/D154584