[PATCH] D155267: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns with floating points.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 10:50:04 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:6115-6118
+          bool isNotNaN =
+              DAG.isKnownNeverNaN(Operand1) && DAG.isKnownNeverNaN(Operand2);
+          bool isNotSNaN =
+              DAG.isKnownNeverSNaN(Operand1) && DAG.isKnownNeverSNaN(Operand2);
----------------
Should try harder to short circuit these calls. You should also start by checking the fast math flags for nnan


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155267/new/

https://reviews.llvm.org/D155267



More information about the llvm-commits mailing list