[PATCH] D155953: [RISCV][MC] Add CLI option to disable branch relaxation

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 08:56:10 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp:32
+static cl::opt<bool> DisableBranchRelaxation("riscv-disable-branch-relaxation",
+                                             cl::init(false));
+
----------------
Drop `false`.

I think positive option names are more common. Perhaps `-riscv-asm-relax-branch=0` since asm and linker relaxation are quite different and the current name can lure users to think the other way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155953/new/

https://reviews.llvm.org/D155953



More information about the llvm-commits mailing list