[PATCH] D155953: [RISCV][MC] Add CLI option to disable branch relaxation

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 08:47:22 PDT 2023


asb added a comment.

I'm supportive of adding a targeted flag to make it easier to write these tests, with the idea that a more public facing flag might later be introduced that alters a full "strict" mode.

I think it might make sense to pass `cl::Hidden` to DisableBranchRelaxation so this doesn't become a documented feature.



================
Comment at: llvm/test/MC/RISCV/long-jump-disable-relax.s:2
+# RUN: llvm-mc -filetype=obj -triple=riscv64 -mattr=+c \
+# RUN:       --riscv-disable-branch-relaxation %s \
+# RUN:     | llvm-objdump -dr -M no-aliases - \
----------------
Nit: I think we normally use the `-single-hyphen-prefix` spelling for llvm-mc opts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155953/new/

https://reviews.llvm.org/D155953



More information about the llvm-commits mailing list