[PATCH] D154280: [LIT] Added an option to llvm-lit to emit the necessary test coverage data, divided per test case

[David Spickett via Phabricator via llvm-commits]

DavidSpickett added inline comments.


================
Comment at: llvm/utils/lit/tests/Inputs/per-test-coverage-by-lit-cfg/per-test-coverage-by-lit-cfg.py:8
+
+llvm_profile_file = os.environ.get('LLVM_PROFILE_FILE')
+print(llvm_profile_file)
----------------
DavidSpickett wrote:
> If I understand correctly, LLVM_PROFILE_FILE should be set by lit itself. So this test could be more robust if it did `env -u LLVM_PROFILE_FILE python...`. The new value for LLVM_PROFILE_FILE should be redefined by lit as part of the test.
Actually ignore me, doing that would remove the value set by LIT because lit is the one that runs the RUN line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154280/new/

https://reviews.llvm.org/D154280