[PATCH] D154280: [LIT] Added an option to llvm-lit to emit the necessary test coverage data, divided per test case

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 08:28:57 PDT 2023


DavidSpickett added inline comments.


================
Comment at: llvm/utils/lit/tests/Inputs/per-test-coverage-by-lit-cfg/per-test-coverage-by-lit-cfg.py:8
+
+llvm_profile_file = os.environ.get('LLVM_PROFILE_FILE')
+print(llvm_profile_file)
----------------
If I understand correctly, LLVM_PROFILE_FILE should be set by lit itself. So this test could be more robust if it did `env -u LLVM_PROFILE_FILE python...`. The new value for LLVM_PROFILE_FILE should be redefined by lit as part of the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154280/new/

https://reviews.llvm.org/D154280



More information about the llvm-commits mailing list