[PATCH] D155623: [AArch64][NFC] Expand SLEEF coverage for ReplaceWithVeclib testing

Fri Jul 21 02:54:49 PDT 2023

paulwalker-arm added a comment.

In D155623#4521933 <https://reviews.llvm.org/D155623#4521933>, @jolanta.jensen wrote:

> In D155623#4521837 <https://reviews.llvm.org/D155623#4521837>, @mgabka wrote:
>
>> If the intention of this patch is to add tests for all LLVM math intrinsics (as you stated in "This patch expands SLEEF coverage for ReplaceWithVeclib testing
>> to all supported math intrinsics."), then I think you do not have here full coverage, for example I do not see tests for llvm.abs, llvm.smax, llvm.smin, llvm.powi, and several other intrinsics
>> full list of intrinsics is available here https://llvm.org/docs/LangRef.html#standard-c-c-library-intrinsics
>
> Well, it reads "all supported math intrinsics" The ones you mention are not supported by SLEEF.

It's not so much about SLEEF but math.h.  The intention of this patch is full coverage of the intrinsics that are used to replace calls to math.h functions.  This is why the integer related intrinsics have been omitted.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155623/new/

https://reviews.llvm.org/D155623