[PATCH] D153587: [GlobPattern] Support brace expansions
Ellis Hoag via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 20 15:47:43 PDT 2023
ellis added a comment.
In D153587#4461154 <https://reviews.llvm.org/D153587#4461154>, @rupprecht wrote:
> LGTM, although this logic is already pretty obscure, so it's hard to follow. I wonder if we have fuzzers hooked up to this so we don't have to worry too much if this misses an edge case.
I'm not sure how we would add fuzzers to this unit test. I could generate random strings and use that to create patterns and matches, but that won't catch correctness issues, just segfaults.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153587/new/
https://reviews.llvm.org/D153587
More information about the llvm-commits
mailing list