[PATCH] D153587: [GlobPattern] Support brace expansions

[Ellis Hoag via Phabricator via llvm-commits]

ellis added a comment.

In D153587#4458387 <https://reviews.llvm.org/D153587#4458387>, @MaskRay wrote:

> There are some interesting test cases like `{a,b}{1,2}`. If we don't intend to support
>
>   % echo {ab\,d}
>   , a b d
>
> we can probably report an error, but I suspect supporting it is easier...

I've added the test case `{a,b}{1,2}` and it works fine. I don't understand the test case `{ab\,d}`. That looks like a brace expansion with one term (`ab,d`). If you meant to use a character class, then I also added that test (`[*?^{},]`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153587/new/

https://reviews.llvm.org/D153587