[lld] a3622ac - [wasm-ld] Switch to xxh3_64bits

[Fangrui Song via llvm-commits]

Author: Fangrui Song
Date: 2023-07-20T10:47:47-07:00
New Revision: a3622ac80be1230a96597a4efb8489d065b0ffc2

URL: https://github.com/llvm/llvm-project/commit/a3622ac80be1230a96597a4efb8489d065b0ffc2
DIFF: https://github.com/llvm/llvm-project/commit/a3622ac80be1230a96597a4efb8489d065b0ffc2.diff

LOG: [wasm-ld] Switch to xxh3_64bits

Similar to recent changes to ELF (e.g., D154813), Mach-O, and COFF to
improve hashing performance.

Reviewed By: dschuff

Differential Revision: https://reviews.llvm.org/D155752

Added: 
    

Modified: 
    lld/test/wasm/build-id.test
    lld/wasm/InputChunks.cpp
    lld/wasm/Writer.cpp

Removed: 
    


################################################################################
diff  --git a/lld/test/wasm/build-id.test b/lld/test/wasm/build-id.test
index a15f4cedcdddda..c5c3cfd737f01b 100644
--- a/lld/test/wasm/build-id.test
+++ b/lld/test/wasm/build-id.test
@@ -43,8 +43,8 @@ foo:
 
 
 # DEFAULT:      Contents of section build_id:
-# DEFAULT-NEXT: 0000 10cdbf99 f76b1f5e ebb2f36a 1bde1d6c  .....k.^...j...l
-# DEFAULT-NEXT: 0010 01
+# DEFAULT-NEXT: 0000 100e228e 4e2fa853 6393b43d ed1d4676
+# DEFAULT-NEXT: 0010 13 .
 
 # SHA1:      Contents of section build_id:
 # SHA1-NEXT: 0000 14ad22e8 54d72438 94af85de 3c5592bd  ..".T.$8....<U..

diff  --git a/lld/wasm/InputChunks.cpp b/lld/wasm/InputChunks.cpp
index a22005fe5f5a7e..f55f54a9509c79 100644
--- a/lld/wasm/InputChunks.cpp
+++ b/lld/wasm/InputChunks.cpp
@@ -451,7 +451,7 @@ void MergeInputChunk::splitStrings(ArrayRef<uint8_t> data) {
       fatal(toString(this) + ": string is not null terminated");
     size_t size = end + 1;
 
-    pieces.emplace_back(off, xxHash64(s.substr(0, size)), true);
+    pieces.emplace_back(off, xxh3_64bits(s.substr(0, size)), true);
     s = s.substr(size);
     off += size;
   }

diff  --git a/lld/wasm/Writer.cpp b/lld/wasm/Writer.cpp
index 7b33a944962a63..25a9c15957f455 100644
--- a/lld/wasm/Writer.cpp
+++ b/lld/wasm/Writer.cpp
@@ -290,7 +290,7 @@ void Writer::writeBuildId() {
   case BuildIdKind::Fast: {
     std::vector<uint8_t> fileHash(8);
     computeHash(fileHash, buf, [](uint8_t *dest, ArrayRef<uint8_t> arr) {
-      support::endian::write64le(dest, xxHash64(arr));
+      support::endian::write64le(dest, xxh3_64bits(arr));
     });
     makeUUID(5, fileHash, buildId);
     break;