[PATCH] D153757: [RFC][TableGen][GlobalISel] Add Combiner Match Table Backend

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh marked an inline comment as done.
Pierre-vh added a comment.

In D153757#4517505 <https://reviews.llvm.org/D153757#4517505>, @MaskRay wrote:

> The test `LLVM :: TableGen/GlobalISelCombinerMatchTableEmitter/pattern-parsing.td` relies on the iteration order of StringMap, which is not guaranteed. The bug is caught by D155789 <https://reviews.llvm.org/D155789>.
>
> I have fixed one bug 6de2735c2428789f99a26bee66030ddfb0841b9e <https://reviews.llvm.org/rG6de2735c2428789f99a26bee66030ddfb0841b9e>, but there are more.
>
>   curl -L 'https://reviews.llvm.org/D155789?download=1' | patch -p1
>   cmake ... -DLLVM_ENABLE_REVERSE_ITERATION=on
>   ninja -C ... check-llvm-tablegen

D155821 <https://reviews.llvm.org/D155821>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153757/new/

https://reviews.llvm.org/D153757