[PATCH] D155718: [InstCombine] Remove unneeded isa<PHINode> check in foldOpIntoPhi

Thu Jul 20 01:37:45 PDT 2023

nikic added a comment.

In D155718#4517738 <https://reviews.llvm.org/D155718#4517738>, @0xdc03 wrote:

> In D155718#4517570 <https://reviews.llvm.org/D155718#4517570>, @nikic wrote:
>
>> The change LGTM, but this patch should not be based on D154064 <https://reviews.llvm.org/D154064>. We should land this first and D154064 <https://reviews.llvm.org/D154064> later.
>
> Okay, I have done this and changed the patch order but the issue I have now is that no changes are visible in the tests introduced in D155726 <https://reviews.llvm.org/D155726>.

The patch order should be D155726 <https://reviews.llvm.org/D155726>, then D155718 <https://reviews.llvm.org/D155718>, then D154064 <https://reviews.llvm.org/D154064>. If you order the patches that way you should see a test change on SwitchTest. It's expected that you don't see a change on BranchTest, which only makes sure that D154064 <https://reviews.llvm.org/D154064> doesn't regress it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155718/new/

https://reviews.llvm.org/D155718