[PATCH] D155718: [InstCombine] Remove unneeded isa<PHINode> check in foldOpIntoPhi
    Dhruv Chawla via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Jul 20 01:26:53 PDT 2023
    
    
  
0xdc03 added a comment.
In D155718#4517570 <https://reviews.llvm.org/D155718#4517570>, @nikic wrote:
> The change LGTM, but this patch should not be based on D154064 <https://reviews.llvm.org/D154064>. We should land this first and D154064 <https://reviews.llvm.org/D154064> later.
Okay, I have done this and changed the patch order but the issue I have now is that no changes are visible in the tests introduced in D155726 <https://reviews.llvm.org/D155726>.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155718/new/
https://reviews.llvm.org/D155718
    
    
More information about the llvm-commits
mailing list