[PATCH] D155638: [llvm-reduce] Reduce function calling convention

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D155638#4515831 <https://reviews.llvm.org/D155638#4515831>, @nikic wrote:

> It's an IR centric view. Calling convention is generally irrelevant for middle-end tests and should be omitted from them.

This isn't a middle end test, it's a general IR tool

> For codegen tests, if the calling convention is relevant to reproduce an issue, that should be determined by the interestingness test.

Requiring additional complexity in interestingness tests is not good. The ideal interestingness test is just run the crashing program, I shouldn't have to hack around odd tooling decisions. The calling convention can and does place IR constraints which this is not considering, and we should try to avoid failing the verifier in any reduction.

Basically I'm fine with reducing fastcc, coldcc, and tailcc to c and opposed to "reducing" any other arbitrary CC. I don't see arbitrarily changing the CC as opening new reduction opportunities, and is easy to manually remove as the final step


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155638/new/

https://reviews.llvm.org/D155638