[PATCH] D155638: [llvm-reduce] Reduce function calling convention

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D155638#4515356 <https://reviews.llvm.org/D155638#4515356>, @arsenm wrote:

> In D155638#4515322 <https://reviews.llvm.org/D155638#4515322>, @dblaikie wrote:
>
>> FWIW, I'd consider this a simplification - if I saw a test case that used a novel/explicit calling convention, I'd probably assume/guess that the CC was load bearing/required/interesting/relevant to the bug. So a test case that doesn't use a novel CC is "simpler" in that sense, to me at least. (it's not a guarantee, it's possible the bug is only reproducible with the default CC, but more often than not that's not going to be the case, I think?)
>
> This is a very x86 centric view. I might go so far as to consider CCC to be the most complex of the calling conventions, others add restrictions

It's an IR centric view. Calling convention is generally irrelevant for middle-end tests and should be omitted from them.

For codegen tests, if the calling convention is relevant to reproduce an issue, that should be determined by the interestingness test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155638/new/

https://reviews.llvm.org/D155638