[PATCH] D155626: [DAG][AArch64] Fix truncated vscale constant types
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 19 13:28:04 PDT 2023
dmgreen updated this revision to Diff 542168.
dmgreen added a comment.
Assert the sizes of the type and APInt match in getVScale.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155626/new/
https://reviews.llvm.org/D155626
Files:
llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
llvm/test/CodeGen/AArch64/sve-vscale.ll
Index: llvm/test/CodeGen/AArch64/sve-vscale.ll
===================================================================
--- llvm/test/CodeGen/AArch64/sve-vscale.ll
+++ llvm/test/CodeGen/AArch64/sve-vscale.ll
@@ -101,6 +101,17 @@
ret i32 %1
}
+define i1 @rdvl_i1() {
+; CHECK-LABEL: rdvl_i1:
+; CHECK: rdvl x8, #-1
+; CHECK-NEXT: asr x8, x8, #4
+; CHECK-NEXT: and w0, w8, #0x1
+; CHECK-NEXT: ret
+ %a = tail call i64 @llvm.vscale.i64()
+ %b = trunc i64 %a to i1
+ ret i1 %b
+}
+
;
; CNTH
;
Index: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
===================================================================
--- llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
+++ llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -1942,10 +1942,8 @@
SDValue SelectionDAG::getVScale(const SDLoc &DL, EVT VT, APInt MulImm,
bool ConstantFold) {
- assert(MulImm.getSignificantBits() <= VT.getSizeInBits() &&
- "Immediate does not fit VT");
-
- MulImm = MulImm.sextOrTrunc(VT.getSizeInBits());
+ assert(MulImm.getBitWidth() == VT.getSizeInBits() &&
+ "APInt size does not match type size!");
if (ConstantFold) {
const MachineFunction &MF = getMachineFunction();
@@ -5751,7 +5749,8 @@
if (OpOpcode == ISD::UNDEF)
return getUNDEF(VT);
if (OpOpcode == ISD::VSCALE && !NewNodesMustHaveLegalTypes)
- return getVScale(DL, VT, N1.getConstantOperandAPInt(0));
+ return getVScale(DL, VT,
+ N1.getConstantOperandAPInt(0).trunc(VT.getSizeInBits()));
break;
case ISD::ANY_EXTEND_VECTOR_INREG:
case ISD::ZERO_EXTEND_VECTOR_INREG:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155626.542168.patch
Type: text/x-patch
Size: 1647 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230719/d8dc1f46/attachment.bin>
More information about the llvm-commits
mailing list