[PATCH] D155626: [DAG][AArch64] Fix truncated vscale constant types

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 13:25:20 PDT 2023

dmgreen added a comment.

I was thinking about it, and I think it would be better to not be sloppy about the APInt passed to getVScale. Similar to existing methods in DAG like getConstant, we should be asserting that the size of the APInt and the type match. Otherwise it should be up to the caller to make them match in a way that is appropriate.

It appears from looking through the calls to getVScale that the version in getNode when truncating the value is the only one where they can be a mismatch.



More information about the llvm-commits mailing list