[PATCH] D155517: [RISC-V] Add proposed mapping for Ztso

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

Meta comment - mostly just chiming is because I'm the person who did the prior implementation, and I want it to be clear I support the direction here.

Given what looks to be a defacto change in the WMO memory model lowering which is going to be widely deployed, we should change the TSO mapping to be compatible with the planned mapping.  The goal of the original change was to allow WMO and TSO objects to be compatible; this change continues in the same spirit, it's just that the assumed WMO lowering is changing.

This case - which we did not know about at the time of the original patch - is exactly why we left ourselves the flexibility of only supporting this experimentally.  We absolutely should not, under any circumstances, promote this out of experimental until the psABI changes for WMO and TSO have finalized.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155517/new/

https://reviews.llvm.org/D155517