[PATCH] D155517: [RISC-V] Add proposed mapping for Ztso

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

>From a first pass through, this appears to match the proposal. I've left one style comment that should be addressed.

I'm not convinced by the new helper in RISCVInstrInfo - might it be cleaner to just pass the RISCVSubtarget to the helpers? I think conventionally we'd put the subtarget argument last for this kind of helper



================
Comment at: llvm/lib/Target/RISCV/RISCVExpandAtomicPseudoInsts.cpp:160
+      return RISCV::LR_W;
+    else
+      return RISCV::LR_W_AQ;
----------------
LLVM style is to not use an `else` after `return`. https://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return

Same applies elsewhere in this patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155517/new/

https://reviews.llvm.org/D155517