[PATCH] D155628: [OpenMP][OpenMPIRBuilder] Make outlined function parameters i64 and ptr

[Jan Sjödin via Phabricator via llvm-commits]

jsjodin added inline comments.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4299
+                        Value *Input, Argument &Arg) {
+  auto Addr = Builder.CreateAlloca(Arg.getType()->isPointerTy()
+                                       ? Arg.getType()
----------------
arsenm wrote:
> jsjodin wrote:
> > arsenm wrote:
> > > Assuming 64-bit pointer
> > > Assuming 64-bit pointer
> > 
> > Yes, should there be a comment?
> > 
> Yes, I was also more thinking it's assuming a 64-bit address space specifically
Yes, both the given address space and the generic. Does LLVM allow different pointer sizes for different address spaces?



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155628/new/

https://reviews.llvm.org/D155628