[PATCH] D155628: [OpenMP][OpenMPIRBuilder] Make outlined function parameters i64 and ptr

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4299
+                        Value *Input, Argument &Arg) {
+  auto Addr = Builder.CreateAlloca(Arg.getType()->isPointerTy()
+                                       ? Arg.getType()
----------------
jsjodin wrote:
> arsenm wrote:
> > Assuming 64-bit pointer
> > Assuming 64-bit pointer
> 
> Yes, should there be a comment?
> 
Yes, I was also more thinking it's assuming a 64-bit address space specifically


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155628/new/

https://reviews.llvm.org/D155628