[PATCH] D155724: Change DW_LLE_baseaddr to DW_LLE_baseaddrx in .debug_loclist section

Shubham Sandeep Rastogi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 09:39:46 PDT 2023


rastogishubham created this revision.
rastogishubham added reviewers: avl, aprantl, JDevlieghere.
rastogishubham added a project: debug-info.
Herald added a subscriber: hiraditya.
Herald added a project: All.
rastogishubham requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

With https://reviews.llvm.org/D154638, the ability to emit a .debug_addr section has been added to dsymutil. With this, instead of emitting a DW_LLE_baseaddr in the .debug_loclist section, a DW_LLE_baseaddrx can be emitted instead, which will allow for more indirection.

I opted for DW_LLE_baseaddrx + DW_LLE_offset_pair because using a DW_LLE_startx_length, because the latter would cause more entries to appear in the .debug_addr section which may lead to the size of the .debug_addr section blowing up considerably


https://reviews.llvm.org/D155724

Files:
  llvm/include/llvm/DWARFLinker/DWARFLinker.h
  llvm/include/llvm/DWARFLinker/DWARFStreamer.h
  llvm/lib/DWARFLinker/DWARFLinker.cpp
  llvm/lib/DWARFLinker/DWARFStreamer.cpp
  llvm/test/tools/dsymutil/ARM/dwarf5-dwarf4-combination-macho.test
  llvm/test/tools/dsymutil/ARM/dwarf5-macho.test
  llvm/test/tools/dsymutil/X86/dwarf5-loclists.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155724.542077.patch
Type: text/x-patch
Size: 14622 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230719/682898da/attachment.bin>


More information about the llvm-commits mailing list