[PATCH] D153744: [LoopUnroll] adjust for new `convergent` semantics

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds marked 3 inline comments as done.
sameerds added inline comments.


================
Comment at: llvm/lib/Analysis/CodeMetrics.cpp:114-126
 
+static bool isConvergenceCtrlIntr(const Instruction &I) {
+  auto *Intrinsic = dyn_cast<IntrinsicInst>(&I);
+  if (!Intrinsic)
+    return false;
+  switch (Intrinsic->getIntrinsicID()) {
+  case Intrinsic::experimental_convergence_entry:
----------------
arsenm wrote:
> sameerds wrote:
> > arsenm wrote:
> > > It might be worth introducing a ConvergenceControlInst subclass of IntrinsicInst 
> > I suppose so, but it seems too early to attempt for an experimental feature!
> Part of the experiment is how inconvenient it is, and also there's no better time to have the convenient code than when implementing it. We have ConstrainedFPIntrinsic for "experimental" features too. It's not a lot of work to add (not that it should be part of this patch)
Does that mean this change is good to go?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153744/new/

https://reviews.llvm.org/D153744