[PATCH] D153744: [LoopUnroll] adjust for new `convergent` semantics
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 18 10:55:07 PDT 2023
arsenm added inline comments.
================
Comment at: llvm/lib/Analysis/CodeMetrics.cpp:114-126
+static bool isConvergenceCtrlIntr(const Instruction &I) {
+ auto *Intrinsic = dyn_cast<IntrinsicInst>(&I);
+ if (!Intrinsic)
+ return false;
+ switch (Intrinsic->getIntrinsicID()) {
+ case Intrinsic::experimental_convergence_entry:
----------------
sameerds wrote:
> arsenm wrote:
> > It might be worth introducing a ConvergenceControlInst subclass of IntrinsicInst
> I suppose so, but it seems too early to attempt for an experimental feature!
Part of the experiment is how inconvenient it is, and also there's no better time to have the convenient code than when implementing it. We have ConstrainedFPIntrinsic for "experimental" features too. It's not a lot of work to add (not that it should be part of this patch)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153744/new/
https://reviews.llvm.org/D153744
More information about the llvm-commits
mailing list