[llvm] 1c36226 - Reland: "[ADT] fix filter_iterator_impl::operator++"

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 14:42:12 PDT 2023


Please include details about the reason for revert and how the new version
of the patch is different from the previous one and how that addresses the
reason for the revert, how it was tested to ensure that issue was addressed.

(& also, perhaps this change needs some unit test coverage?)

On Fri, Jul 7, 2023 at 7:47 AM Alex Brachet via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
> Author: Alex Brachet
> Date: 2023-07-07T14:47:22Z
> New Revision: 1c3622674807c0790aee6b7eda686c72c090614e
>
> URL:
> https://github.com/llvm/llvm-project/commit/1c3622674807c0790aee6b7eda686c72c090614e
> DIFF:
> https://github.com/llvm/llvm-project/commit/1c3622674807c0790aee6b7eda686c72c090614e.diff
>
> LOG: Reland: "[ADT] fix filter_iterator_impl::operator++"
>
> Added:
>
>
> Modified:
>     llvm/include/llvm/ADT/STLExtras.h
>
> Removed:
>
>
>
>
> ################################################################################
> diff  --git a/llvm/include/llvm/ADT/STLExtras.h
> b/llvm/include/llvm/ADT/STLExtras.h
> index 7edc582636c772..6fbe2ba54fedf5 100644
> --- a/llvm/include/llvm/ADT/STLExtras.h
> +++ b/llvm/include/llvm/ADT/STLExtras.h
> @@ -535,6 +535,16 @@ class filter_iterator_impl<WrappedIteratorT,
> PredicateT,
>                         PredicateT Pred)
>        : BaseT(Begin, End, Pred) {}
>
> +  filter_iterator_impl &operator++() {
> +    BaseT::operator++();
> +    return *this;
> +  }
> +
> +  filter_iterator_impl &operator++(int) {
> +    BaseT::operator++();
> +    return *this;
> +  }
> +
>    filter_iterator_impl &operator--() {
>      BaseT::operator--();
>      findPrevValid();
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230718/f4b424ec/attachment.html>


More information about the llvm-commits mailing list