<div dir="ltr">Please include details about the reason for revert and how the new version of the patch is different from the previous one and how that addresses the reason for the revert, how it was tested to ensure that issue was addressed.<br><br>(& also, perhaps this change needs some unit test coverage?)</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jul 7, 2023 at 7:47 AM Alex Brachet via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Alex Brachet<br>
Date: 2023-07-07T14:47:22Z<br>
New Revision: 1c3622674807c0790aee6b7eda686c72c090614e<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/1c3622674807c0790aee6b7eda686c72c090614e" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/1c3622674807c0790aee6b7eda686c72c090614e</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/1c3622674807c0790aee6b7eda686c72c090614e.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/1c3622674807c0790aee6b7eda686c72c090614e.diff</a><br>
<br>
LOG: Reland: "[ADT] fix filter_iterator_impl::operator++"<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
llvm/include/llvm/ADT/STLExtras.h<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/llvm/include/llvm/ADT/STLExtras.h b/llvm/include/llvm/ADT/STLExtras.h<br>
index 7edc582636c772..6fbe2ba54fedf5 100644<br>
--- a/llvm/include/llvm/ADT/STLExtras.h<br>
+++ b/llvm/include/llvm/ADT/STLExtras.h<br>
@@ -535,6 +535,16 @@ class filter_iterator_impl<WrappedIteratorT, PredicateT,<br>
PredicateT Pred)<br>
: BaseT(Begin, End, Pred) {}<br>
<br>
+ filter_iterator_impl &operator++() {<br>
+ BaseT::operator++();<br>
+ return *this;<br>
+ }<br>
+<br>
+ filter_iterator_impl &operator++(int) {<br>
+ BaseT::operator++();<br>
+ return *this;<br>
+ }<br>
+<br>
filter_iterator_impl &operator--() {<br>
BaseT::operator--();<br>
findPrevValid();<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>