[PATCH] D155255: [SCEV] Don't update the range value if empty

[Nikita Popov via Phabricator via llvm-commits]

nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.

To be clear, the test I expected to see here is just this:

  define ptr @size_max() {
    %alloc = call nonnull ptr @malloc(i64 -1)
    ret ptr %alloc
  }

This is enough to reproduce the assertion failure for me.



================
Comment at: llvm/test/Analysis/ScalarEvolution/malloc.ll:4
 
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+
----------------
Why does this need a data layout?


================
Comment at: llvm/test/Analysis/ScalarEvolution/malloc.ll:34
+entry:
+  %call443 = tail call nonnull ptr @_Znam(i64 -1)
+  br label %for.cond9
----------------
Can reuse `malloc`.


================
Comment at: llvm/test/Analysis/ScalarEvolution/malloc.ll:40
+  %scevgep = getelementptr i8, ptr %lsr.iv, i64 4
+  br label %for.cond9
+}
----------------
This loop shouldn't be necessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155255/new/

https://reviews.llvm.org/D155255