[PATCH] D155255: [SCEV] Don't update the range value if empty

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM thanks. I think the title still needs updating to match the latest implementation.



================
Comment at: llvm/test/Analysis/ScalarEvolution/malloc.ll:28
 
+define void @patatino() {
+; CHECK-LABEL: 'patatino'
----------------
it would probably be good to use a more descriptive name making it clear that this is with operator new and full range? Also, could mention the issue


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/scev-operator-new.ll:1
+; RUN: opt < %s -passes=loop-reduce -S | FileCheck %s
+
----------------
Does this test add anything over the one in `malloc.ll`? If not, probably best to remove it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155255/new/

https://reviews.llvm.org/D155255