[PATCH] D155441: [ADT] Remove SFINAE constraint from llvm::iterator_range ctor for gcc-7

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/ADT/iterator_range.h:47
+#if __GNUC__ == 7
+  // Be careful no to break gcc-7 on the mlir target.
+  // See https://github.com/llvm/llvm-project/issues/63843
----------------
steakhal wrote:
> MaskRay wrote:
> > If you know what things are specifically broken, better to use something like:
> > 
> > Work around a bug that ...
> The thing is that usually I don't write generic code. So I gave up after 4 hours, thus I don't really know why it doesn't work for gcc-8.
> So I cannot be more specific.
> I had a quick look at gcc-8 release notes, but I couldn't find anything related to templates.
immolo from Gentoo reports a build success with GCC 8, so only GCC 7 needs the workaround.

... and reported a typo (no => not): "Be careful not to break gcc-7 on the mlir target."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155441/new/

https://reviews.llvm.org/D155441