[PATCH] D155441: [ADT] Remove SFINAE constraint from llvm::iterator_range ctor for gcc-7

[Balázs Benics via Phabricator via llvm-commits]

steakhal added a comment.

In D155441#4507877 <https://reviews.llvm.org/D155441#4507877>, @MaskRay wrote:

>> Allegedly, GCC-8 and above builds just fine.
>
> It would be nice to test this:)

I'll check that tomorrow.



================
Comment at: llvm/include/llvm/ADT/iterator_range.h:47
+#if __GNUC__ == 7
+  // Be careful no to break gcc-7 on the mlir target.
+  // See https://github.com/llvm/llvm-project/issues/63843
----------------
MaskRay wrote:
> If you know what things are specifically broken, better to use something like:
> 
> Work around a bug that ...
The thing is that usually I don't write generic code. So I gave up after 4 hours, thus I don't really know why it doesn't work for gcc-8.
So I cannot be more specific.
I had a quick look at gcc-8 release notes, but I couldn't find anything related to templates.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155441/new/

https://reviews.llvm.org/D155441