[PATCH] D74162: [Inliner] Inlining should honor nobuiltin attributes

[Joseph Huber via Phabricator via llvm-commits]

jhuber6 added a comment.
Herald added subscribers: hoy, wlei, ormris, foad, ChuanqiXu, wenlei.
Herald added a project: All.

I was discussing this patch with @arsenm after investigating why the calls to `libc` functions weren't being inlined on the GPU. What was the motivation for the original change? I figured it would make no difference if we inlined a function that doesn't allow built-ins into one that does. This is problematic because it prevents us from inlining any function from the LLVM C library under LTO. I'd like a way to at least work around this in the short term, but I'd like some context for why this was introduced.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74162/new/

https://reviews.llvm.org/D74162