[PATCH] D155199: [NFC][XCOFF] Use common function to calculate file offset

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 11:34:44 PDT 2023


scott.linder accepted this revision.
scott.linder added a comment.
This revision is now accepted and ready to land.

LGTM, although I'm also fine with a more "functional" approach where `RawPointer` is returned rather than mutated via reference! I'll leave that between you and @stephenpeckham

Also, if you want to add a TODO for the cleanup @stephenpeckham suggests feel free to do so when landing! I'm at least happy that the function is now virtual, rather than just aliased in a subclass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155199/new/

https://reviews.llvm.org/D155199



More information about the llvm-commits mailing list