[PATCH] D155418: [RISCV] Add bf16 as a valid type for the FPR16 register class.

Jun Sha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 16 23:20:45 PDT 2023


joshua-arch1 added a comment.

> Can you explain why it will be hard to maintain? The complexity of supporting Zfinx/Zdinx/Zhinx and all the special patterns for Zfhmin already seems way worse than passing an extra Valuetype to some classes.

I see. It seems that passing Valuetype to some codegen classes is the most effective way to address this issue if you want to use the same register class for different types. What we need to do now is to confirm that reusing FPR16 for bf16 is actually better than adding a new register class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155418/new/

https://reviews.llvm.org/D155418



More information about the llvm-commits mailing list