[PATCH] D155214: Preserve important metadata in JumpThreadingPass::unfoldSelectInstr

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/test/Transforms/JumpThreading/preserve-select-unfold.ll:4
+target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024"
+target triple = "spir64-unknown-unknown-intelfpga"
+
----------------
Use update_test_checks.py with --check-globals, remove data layout and triple.


================
Comment at: llvm/test/Transforms/JumpThreading/preserve-select-unfold.ll:11
+; CHECK-LAB: select.unfold:
+; CHECK: br label %A, !llvm.loop ![[INFO:.*]]
+
----------------
The metadata you are testing for appear to already be present without your patch: https://llvm.godbolt.org/z/GqW8oo5fb


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155214/new/

https://reviews.llvm.org/D155214