[PATCH] D155252: [PseudoProbe] Remove unnecessary asserts about non-zero discriminator.

Fri Jul 14 19:53:02 PDT 2023

wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

In D155252#4501305 <https://reviews.llvm.org/D155252#4501305>, @hoy wrote:

> In D155252#4499632 <https://reviews.llvm.org/D155252#4499632>, @wenlei wrote:
>
>> In general if the effort to make sure probe has zero discriminator is too much, it makes sense to just rely on discriminator clean up instead during FS discriminator assignment for probes. I'm curious though what exposed this case? IIRC, we didn't hit this assert for a while now.
>
> Yeah, it was good for a while until incrPGO was on. I suspect incrPGO opened more opportunity for optimizations and exposed this issue.

Since we already did many fixes, if it's just one or two more fixes, do you think we could try to keep it?

I don't have a strong opinion, so accepting anyways.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155252/new/

https://reviews.llvm.org/D155252