[PATCH] D155252: [PseudoProbe] Remove unnecessary asserts about non-zero discriminator.
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 14 09:19:22 PDT 2023
hoy added a comment.
In D155252#4499632 <https://reviews.llvm.org/D155252#4499632>, @wenlei wrote:
> In general if the effort to make sure probe has zero discriminator is too much, it makes sense to just rely on discriminator clean up instead during FS discriminator assignment for probes. I'm curious though what exposed this case? IIRC, we didn't hit this assert for a while now.
Yeah, it was good for a while until incrPGO was on. I suspect incrPGO opened more opportunity for optimizations and exposed this issue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155252/new/
https://reviews.llvm.org/D155252
More information about the llvm-commits
mailing list