[PATCH] D155343: MachineSink: Fix sinking VGPR def out of a divergent loop

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 15:26:32 PDT 2023


nickdesaulniers added a comment.

Not sure what to make of that Fixes tag. The change to `isInlineAsmBrIndirectTarget` LGTM; unsure about the rest.



================
Comment at: llvm/lib/CodeGen/MachineSink.cpp:1024
+
+  MachineBasicBlock::const_iterator InsertPos =
+      SuccToSinkTo->SkipPHIsAndLabels(SuccToSinkTo->begin());
----------------
consider using `const auto` here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155343/new/

https://reviews.llvm.org/D155343



More information about the llvm-commits mailing list