[PATCH] D155284: [GlobalISel] Fix infinite loop in reassociation combine

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 05:14:10 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/postlegalizer-combiner-reassoc.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 3
+# RUN: llc -global-isel -march=amdgcn -run-pass=amdgpu-postlegalizer-combiner -verify-machineinstrs -o - %s | FileCheck %s
+
----------------
don't need -global-isel


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/postlegalizer-combiner-reassoc.mir:21
+    %0:_(s32) = COPY $vgpr0
+    %7:_(s32) = G_CONSTANT i32 0
+    %13:_(s32) = G_CONSTANT i32 1
----------------
should run-pass=none to compact the register numbers, it's sometimes annoying when the register numbers actually tested don't match the ones in the file


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155284/new/

https://reviews.llvm.org/D155284



More information about the llvm-commits mailing list