[PATCH] D153453: [MemCpyOpt] implement single BB stack-move optimization which unify the static unescaped allocas

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 04:26:19 PDT 2023


serge-sans-paille added a comment.

In D153453#4500396 <https://reviews.llvm.org/D153453#4500396>, @nikic wrote:

> We shouldn't use dominates() in this patch, as it's not always semantically correct.

Can you explain why?

> Just the BB check you added should be enough to fix the issue, no?

Yes, that was my first patch and I tested it successfully on firefox.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153453/new/

https://reviews.llvm.org/D153453



More information about the llvm-commits mailing list